Register forum user name Search FAQ

Gammon Forum

Notice: Any messages purporting to come from this site telling you that your password has expired, or that you need to verify your details, confirm your email, resolve issues, making threats, or asking for money, are spam. We do not email users with any such messages. If you have lost your password you can obtain a new one by using the password reset link.

Due to spam on this forum, all posts now need moderator approval.

 Entire forum ➜ MUSHclient ➜ General ➜ minor modification in var.lua

minor modification in var.lua

It is now over 60 days since the last post. This thread is closed.     Refresh page


Posted by Unia_nt   (17 posts)  Bio
Date Tue 29 Dec 2015 03:48 AM (UTC)
Message
var.xx return a string, when do comparing with a number in lua will lead error, so I changed the return as :

return tonumber(GetVariable (name) ) or GetVariable (name)

in var.lua and fixed the issue.
Top

Posted by Fiendish   USA  (2,555 posts)  Bio   Global Moderator
Date Reply #1 on Tue 29 Dec 2015 11:36 AM (UTC)

Amended on Tue 29 Dec 2015 11:38 AM (UTC) by Fiendish

Message
This would unfortunately break compatibility with anything already using the file. If you know the stored value is a number (which you must in order to do your comparison that way), it would be safer to tonumber the value on the outside of the access instead of inside of it.

So like "yournumber == tonumber(var.foo)" instead of "yournumber == var.foo"

https://github.com/fiendish/aardwolfclientpackage
Top

Posted by Nick Gammon   Australia  (23,173 posts)  Bio   Forum Administrator
Date Reply #2 on Wed 30 Dec 2015 05:00 AM (UTC)
Message
I agree with Fiendish. For example:


print (tonumber (" 42 "))


That prints 42, and discards the spaces. Your change would corrupt existing variables, quite possibly.

- Nick Gammon

www.gammon.com.au, www.mushclient.com
Top

The dates and times for posts above are shown in Universal Co-ordinated Time (UTC).

To show them in your local time you can join the forum, and then set the 'time correction' field in your profile to the number of hours difference between your location and UTC time.


13,104 views.

It is now over 60 days since the last post. This thread is closed.     Refresh page

Go to topic:           Search the forum


[Go to top] top

Information and images on this site are licensed under the Creative Commons Attribution 3.0 Australia License unless stated otherwise.